spelling

bin/sau

@@ -46,6 +46,12 @@ def init():
 
 def fork_and_reboot():
     log = logging.getLogger(sau.LOGNAME)
+    if os.path.exists('/proc/1/comm'):
+        with open('/proc/1/comm', 'r') as f:
+            if f.readline().strip() == 'systemd':
+                os.execl('/usr/bin/systemctl', 'reboot')
+                log.error("Failed to execl?")
+                sys.exit(1)
     try:
         pid = os.fork()
         if pid != 0:

config.cfg

@@ -16,9 +16,14 @@ version_sensitivity=1
 # not close all deleted files (any platform)
 do_reboot=no
 
-# FreeBSD system update (freebsd-update fetch install, not freebsd-update upgrade)
+# Attempt to do a system upgrade
+# FreeBSD: upgrade to latest patch version using freebsd-update fetch install
+# Gentoo: allow upgrade of sys-kernel/-packages, clean old kernels, and update grub-config
 do_system_upgrade=yes
 
+# On Gentoo kernel upgrades, remove all but the last keep_kernels kernels from /boot
+keep_kernels=4
+
 # upgrade packages
 do_package_upgrade=yes
 
@@ -46,9 +51,7 @@ syslog_loglevel=info
 # Gentoo uses the category/package naming scheme
 dev-db/postgresql=1
 
-# Gentoo kernel stuff should be updated manually
+# It's safer to upgrade zfs manually
-sys-kernel/gentoo-sources=99
-sys-kernel/spl=99
 sys-fs/zfs-kmod=99
 
 # FreeBSD uses the short package name (without category)

sau/gentoo.py

@@ -7,8 +7,10 @@ import sau.helpers
 
 EIX_SYNC_PATH='/usr/bin/eix-sync'
 RC_SERVICE_PATH='/sbin/rc-service'
+SYSTEMCTL='/usr/bin/systemctl'
 EMERGE_PATH='/usr/bin/emerge'
 EQUERY_PATH='/usr/bin/equery'
+EMAINT_PATH='/usr/sbin/emaint'
 GRUB_MKCONFIG='/usr/sbin/grub-mkconfig'
 
 # parsing output from eix -Ttnc
@@ -19,6 +21,10 @@ slot_re = re.compile('^(\(~\))?([^\(]+)(\([^\)]+\))$')
 def identify_service_from_bin(exe):
     log = logging.getLogger(sau.LOGNAME)
 
+    with open('/proc/1/comm', 'r') as f:
+        if f.readline().strip() == 'systemd':
+            init_script_re = re.compile(r'[^/]*(.*)\.service$')
+        else:
             init_script_re = re.compile(r'/etc/init\.d/(.*)')
 
     cmd = [ EQUERY_PATH, '-Cq', 'b', exe ]
@@ -54,6 +60,10 @@ def identify_service_from_bin(exe):
 
 def restart_service(service):
     log = logging.getLogger(sau.LOGNAME)
+    with open('/proc/1/comm', 'r') as f:
+        if f.readline().strip() == 'systemd':
+            cmd = [ SYSTEMCTL, 'restart', service ]
+        else:
             cmd = [ RC_SERVICE_PATH, service, 'restart' ]
     ret, out, err = sau.helpers.exec_cmd(cmd)
 
@@ -88,6 +98,17 @@ def _sync_portage():
         for line in err.splitlines():
             log.warning("stderr: {}".format(line))
 
+    cmd = [ EMAINT_PATH, '-f', 'all' ]
+    ret, out, err = sau.helpers.exec_cmd(cmd, timeout=3600)
+
+    if ret != 0:
+        log.warning("emaint failed:")
+        for line in out.splitlines():
+            log.warning("stdout: {}".format(line))
+        for line in err.splitlines():
+            log.warning("stderr: {}".format(line))
+
+
 
 
 def pkg_upgrade():
@@ -195,13 +216,17 @@ def pkg_upgrade():
                 if line.startswith(' * '):
                     log.warning(line)
 
-    if do_grub:
+    if do_grub and os.path.exists(GRUB_MKCONFIG):
+        keep_kernels = conf.getint('default', 'keep_kernels', fallback=4)
+        if keep_kernels < 1:
+            log.error('keep_kernels cannot be less than one; falling back to default')
+            keep_kernels = 4
         for root, dirs, files in os.walk('/boot'):
             for sysfile in ['config', 'initramfs', 'System.map', 'vmlinuz']:
                 match = sorted(
                         [f for f in files if f.startswith(f'{sysfile}-')],
                         reverse=True)
-                for f in match[4:]:
+                for f in match[keep_kernels:]:
                     log.debug(f"Removing old kernel file {f}")
                     os.remove(os.path.join(root, f))
             break