Compare commits

..

9 Commits

2 changed files with 39 additions and 15 deletions

View File

@ -47,6 +47,10 @@ def parse_args():
'-L', '--no-lock', '-L', '--no-lock',
help='Allow multiple simultanious executions of this cron job', help='Allow multiple simultanious executions of this cron job',
action='store_true') action='store_true')
parser.add_argument(
'-r', '--restart',
help='Restart the process if not running; exit with success if previous instance is running',
action='store_true')
parser.add_argument( parser.add_argument(
@ -79,7 +83,7 @@ def parse_args():
args = parser.parse_args() args = parser.parse_args()
if not args.name: if not args.name:
args.name = [os.path.basename(args.command[0])] args.name = os.path.basename(args.command[0])
return args return args
@ -104,7 +108,7 @@ def exec_command(args, outfile, errfile, resfile):
proc.terminate() proc.terminate()
proc.communicate(timeout=10) proc.communicate(timeout=10)
now=datetime.datetime.utcnow() now=datetime.datetime.now()
nowstr=now.strftime('%Y-%m-%d_%H%M.%S') nowstr=now.strftime('%Y-%m-%d_%H%M.%S')
resfile.write('{}\n{}'.format(nowstr, proc.returncode)) resfile.write('{}\n{}'.format(nowstr, proc.returncode))
return proc.returncode return proc.returncode
@ -159,12 +163,15 @@ def print_runs(runs, clean=True):
print("\n\n") print("\n\n")
if clean: if clean:
for run in runs: for run in runs:
shutil.rmtree(run) try:
shutil.rmtree(run)
except FileNotFoundError:
pass
def main(): def main():
time_format = '%Y-%m-%d_%H%M' time_format = '%Y-%m-%d_%H%M'
args = parse_args() args = parse_args()
now = datetime.datetime.utcnow() now = datetime.datetime.now()
nowstr = now.strftime(time_format) nowstr = now.strftime(time_format)
libdir = os.path.join(args.cachedir[0], args.name, nowstr) libdir = os.path.join(args.cachedir[0], args.name, nowstr)
lckdir = os.path.join(args.lockdir[0], args.name) lckdir = os.path.join(args.lockdir[0], args.name)
@ -178,13 +185,20 @@ def main():
resfile = os.path.join(libdir, 'result') resfile = os.path.join(libdir, 'result')
success = True success = True
has_lock = True
with open(outfile, 'w') as o, open(errfile, 'w+') as e, open(resfile, 'w') as r: with open(outfile, 'w') as o, open(errfile, 'w+') as e, open(resfile, 'w') as r:
if args.no_lock or aquire_lock(lckfile): if args.no_lock:
res = exec_command(args, o, e, r) res = exec_command(args, o, e, r)
else: else:
e.write("CRONWRAPPER: Unable to aquire lock, previous instance still running?\n") has_lock = aquire_lock(lckfile)
r.write("\nFalse\n") if has_lock:
res = False res = exec_command(args, o, e, r)
elif args.restart:
res = 0
else:
e.write("CRONWRAPPER: Unable to aquire lock, previous instance still running?\n")
r.write("\nFalse\n")
res = False
if res in args.success_exit_codes: if res in args.success_exit_codes:
# Possible success, check error output # Possible success, check error output
@ -204,10 +218,16 @@ def main():
previous_runs = {} previous_runs = {}
for root, dirs, files in os.walk(os.path.join(args.cachedir[0], args.name)): for root, dirs, files in os.walk(os.path.join(args.cachedir[0], args.name)):
previous_runs = { for d in dirs:
os.path.join(root, d): datetime.datetime.strptime(d, time_format) if datetime.datetime.strptime(d, time_format) < datetime.datetime.strptime(nowstr, time_format):
for d in dirs with open(os.path.join(root, d, 'result'), 'r') as f:
if datetime.datetime.strptime(d, time_format) < datetime.datetime.strptime(nowstr, time_format)} try:
retcode = f.read().splitlines()[-1]
except IndexError:
# Previous run is probably not completed yet, ignore
# this entry
continue
previous_runs[os.path.join(root, d)] = datetime.datetime.strptime(d, time_format)
break break
if success: if success:
@ -215,7 +235,10 @@ def main():
if previous_runs: if previous_runs:
print("Success after {} failed runs\n".format(len(previous_runs))) print("Success after {} failed runs\n".format(len(previous_runs)))
print_runs(previous_runs.keys()) print_runs(previous_runs.keys())
shutil.rmtree(libdir) try:
shutil.rmtree(libdir)
except FileNotFoundError:
pass
return 0 return 0
@ -237,7 +260,8 @@ def main():
print("Cronjob failed\n") print("Cronjob failed\n")
print_runs([libdir], clean=False) print_runs([libdir], clean=False)
release_lock(lckfile) if has_lock:
release_lock(lckfile)
if __name__ == '__main__': if __name__ == '__main__':
sys.exit(main()) sys.exit(main())

View File

@ -5,7 +5,7 @@ with open('README.md', 'r') as fh:
setuptools.setup( setuptools.setup(
name='cronwrapper', name='cronwrapper',
version='0.1.1', version='0.1.5',
author='Fredrik Eriksson', author='Fredrik Eriksson',
author_email='feffe@fulh.ax', author_email='feffe@fulh.ax',
description='A small wrapper to handle cronjob failures', description='A small wrapper to handle cronjob failures',