cronwrapper/__init__.py

@@ -47,10 +47,6 @@ def parse_args():
             '-L', '--no-lock',
             help='Allow multiple simultanious executions of this cron job',
             action='store_true')
-    parser.add_argument(
-            '-r', '--restart',
-            help='Restart the process if not running; exit with success if previous instance is running',
-            action='store_true')
 
 
     parser.add_argument(
@@ -108,7 +104,7 @@ def exec_command(args, outfile, errfile, resfile):
             proc.terminate()
             proc.communicate(timeout=10)
 
-    now=datetime.datetime.now()
+    now=datetime.datetime.utcnow()
     nowstr=now.strftime('%Y-%m-%d_%H%M.%S')
     resfile.write('{}\n{}'.format(nowstr, proc.returncode))
     return proc.returncode
@@ -163,15 +159,12 @@ def print_runs(runs, clean=True):
         print("\n\n")
     if clean:
         for run in runs:
-            try:
-                shutil.rmtree(run)
-            except FileNotFoundError:
-                pass
+            shutil.rmtree(run)
 
 def main():
     time_format = '%Y-%m-%d_%H%M'
     args = parse_args()
-    now = datetime.datetime.now()
+    now = datetime.datetime.utcnow()
     nowstr = now.strftime(time_format)
     libdir = os.path.join(args.cachedir[0], args.name, nowstr)
     lckdir = os.path.join(args.lockdir[0], args.name)
@@ -185,20 +178,13 @@ def main():
     resfile = os.path.join(libdir, 'result')
 
     success = True
-    has_lock = True
     with open(outfile, 'w') as o, open(errfile, 'w+') as e, open(resfile, 'w') as r:
-        if args.no_lock:
+        if args.no_lock or aquire_lock(lckfile):
             res = exec_command(args, o, e, r)
         else:
-            has_lock = aquire_lock(lckfile)
-            if has_lock:
-                res = exec_command(args, o, e, r)
-            elif args.restart:
-                res = 0
-            else:
-                e.write("CRONWRAPPER: Unable to aquire lock, previous instance still running?\n")
-                r.write("\nFalse\n")
-                res = False
+            e.write("CRONWRAPPER: Unable to aquire lock, previous instance still running?\n")
+            r.write("\nFalse\n")
+            res = False
 
         if res in args.success_exit_codes:
             # Possible success, check error output
@@ -218,16 +204,10 @@ def main():
 
     previous_runs = {}
     for root, dirs, files in os.walk(os.path.join(args.cachedir[0], args.name)):
-        for d in dirs:
-            if datetime.datetime.strptime(d, time_format) < datetime.datetime.strptime(nowstr, time_format):
-                with open(os.path.join(root, d, 'result'), 'r') as f:
-                    try:
-                        retcode = f.read().splitlines()[-1]
-                    except IndexError:
-                        # Previous run is probably not completed yet, ignore
-                        # this entry
-                        continue
-                previous_runs[os.path.join(root, d)] = datetime.datetime.strptime(d, time_format)
+        previous_runs = {
+                os.path.join(root, d): datetime.datetime.strptime(d, time_format) 
+                for d in dirs 
+                if datetime.datetime.strptime(d, time_format) < datetime.datetime.strptime(nowstr, time_format)}
         break
 
     if success:
@@ -235,10 +215,7 @@ def main():
         if previous_runs:
             print("Success after {} failed runs\n".format(len(previous_runs)))
             print_runs(previous_runs.keys())
-        try:
-            shutil.rmtree(libdir)
-        except FileNotFoundError:
-            pass
+        shutil.rmtree(libdir)
         return 0 
 
 
@@ -260,8 +237,7 @@ def main():
         print("Cronjob failed\n")
         print_runs([libdir], clean=False)
 
-    if has_lock:
-        release_lock(lckfile)
+    release_lock(lckfile)
 
 if __name__ == '__main__':
     sys.exit(main())

setup.py

@@ -5,7 +5,7 @@ with open('README.md', 'r') as fh:
 
 setuptools.setup(
         name='cronwrapper',
-        version='0.1.5',
+        version='0.1.2',
         author='Fredrik Eriksson',
         author_email='feffe@fulh.ax',
         description='A small wrapper to handle cronjob failures',